Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANN version #1

Open
naodaihuang opened this issue May 9, 2019 · 7 comments
Open

ANN version #1

naodaihuang opened this issue May 9, 2019 · 7 comments

Comments

@naodaihuang
Copy link

Can you add a simpler ANN version of LGT? In Smyl Slawek's 2015 paper Appendix 1, it has implementation of AAN, and "Remove or comment out highlighted lines for ANN model". It would be similar to ses in forecast package.

Will the ANN version work for time series that has negative values?

@slaweks17
Copy link
Collaborator

Hi,
Yes, it would be possible. I am actually planning to (re)implement a few ETS models in this framework, for the paper we are writing with Christoph Bergmeir. But does it make sense to expose it? I doubt it, more code to test, document etc. :-)
Negative values make you to use the additive seasonality, and this is more difficult to fit (it would probably end up "behind the scenes" as multiplicative, i.e. some seasonality component multiplied by level)
Cheers.

@naodaihuang
Copy link
Author

It makes a lot of sense to have an ANN standalone function since it could be 10-100 times faster than current implementation? Many other Bayesian methods were not well accepted in practice because of speed issues. Only ANN, no others. It's like in forecast package there's SES for ANN, and others are still in ETS. There are many time series out there essentially ANN with no seasonality. I guess then the input can take negative values assuming no seasonality? Thanks for the great work by the way

@cbergmeir
Copy link
Owner

cbergmeir commented May 11, 2019 via email

@naodaihuang
Copy link
Author

yes ses is just a wrapper, but as I look at the stan code here, if it's ANN then fewer parameters and distributions needed, I guess it can be a lot faster

Repository owner deleted a comment from slaweks17 May 13, 2019
@slaweks17
Copy link
Collaborator

You are right, it is much faster. I implemented my version of damped Holt Winters and it is at least 10 times faster, and also, on M3 yearly dataset, beats ARIMA and ETS.
So I warmed up to the idea of adding it, but then I tried to write a seasonal version and started having failures of Rstan (sampling does not work or kills R). I have 2 days trying various combinations, nothing works. I asked a question on RStan forum - no answer so far.
But, this was all on Windows. I will try to do it on Linux.

@slaweks17
Copy link
Collaborator

Or wait till RStan 2.19 comes out.

@naodaihuang
Copy link
Author

I'd suggest just a very simple one without seasonality consideration. Many time series are not seasonal, and people can do their own seasonality trend decomposition anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants