From 36d3cfe0b7db20afd854e46c1dc358ccd9aa1419 Mon Sep 17 00:00:00 2001
From: Meis <meissadia@gmail.com>
Date: Wed, 1 Nov 2023 14:46:45 -0600
Subject: [PATCH] feat: Support configuration options for Atomic components
 feat: [Mulitselect] Make rendering of selected Tags configurable feat:
 [Multiselect] Make maximum number of selections configurable

---
 .../src/utilities/atomic-helpers.js           |  5 +--
 .../cfpb-forms/src/organisms/Multiselect.js   | 35 +++++++++++++++----
 .../src/organisms/MultiselectModel.js         |  6 ++--
 .../cfpb-forms/src/organisms/multiselect.less |  2 +-
 4 files changed, 36 insertions(+), 12 deletions(-)

diff --git a/packages/cfpb-atomic-component/src/utilities/atomic-helpers.js b/packages/cfpb-atomic-component/src/utilities/atomic-helpers.js
index a06102dba5..97a3d5085f 100755
--- a/packages/cfpb-atomic-component/src/utilities/atomic-helpers.js
+++ b/packages/cfpb-atomic-component/src/utilities/atomic-helpers.js
@@ -100,12 +100,13 @@ function setInitFlag(element) {
 
 /**
  * @param {string} selector - Selector to search for in the document.
+ * @param {Object} config - Configuration will be provided to the Constructor's init()
  * @param {Function} Constructor - A constructor function.
  * @param {HTMLElement} [scope] - A dom node in which to query the selector.
  *   If not supplied, it defaults to the `document`.
  * @returns {Array} List of instances that were instantiated.
  */
-function instantiateAll(selector, Constructor, scope) {
+function instantiateAll(selector, Constructor, scope, config = {}) {
   const base = scope || document;
   const elements = base.querySelectorAll(selector);
   const insts = [];
@@ -115,7 +116,7 @@ function instantiateAll(selector, Constructor, scope) {
     element = elements[i];
     if (contains(element, INIT_FLAG) === false) {
       inst = new Constructor(element);
-      inst.init();
+      inst.init(config);
       insts.push(inst);
     }
   }
diff --git a/packages/cfpb-forms/src/organisms/Multiselect.js b/packages/cfpb-forms/src/organisms/Multiselect.js
index 38118d5f37..85c93dc861 100644
--- a/packages/cfpb-forms/src/organisms/Multiselect.js
+++ b/packages/cfpb-forms/src/organisms/Multiselect.js
@@ -49,6 +49,7 @@ function Multiselect(element) {
   let _placeholder;
   let _model;
   let _options;
+  let _config; // Configuration object
 
   // Markup elems, convert this to templating engine in the future.
   let _containerDom;
@@ -285,10 +286,13 @@ function Multiselect(element) {
         const dataOptionSel = '[data-option="' + option.value + '"]';
         const _selectionsItemDom = _selectionsDom.querySelector(dataOptionSel);
 
-        if (typeof _selectionsItemDom !== 'undefined') {
-          _selectionsDom.removeChild(_selectionsItemDom);
+        // If the <Tag> exists
+        if (typeof _selectionsItemDom !== 'undefined' && _selectionsItemDom) {
+          _selectionsDom?.removeChild(_selectionsItemDom);
         }
-      } else {
+      }
+      // Else, if we are configured to display <Tag>s then render them
+      else if (_config?.renderTags && _selectionsDom) {
         _createSelectedItem(_selectionsDom, option);
       }
       _model.toggleOption(optionIndex);
@@ -512,7 +516,8 @@ function Multiselect(element) {
 
       _optionItemDoms.push(optionsItemDom);
 
-      if (isChecked) {
+      // Create <Tag> if enabled
+      if (isChecked && _config?.renderTags) {
         _createSelectedItem(_selectionsDom, option);
       }
     }
@@ -527,9 +532,10 @@ function Multiselect(element) {
 
   /**
    * Set up and create the multiselect.
+   * @param _modelConfig Multiselect configuration options
    * @returns {Multiselect} An instance.
    */
-  function init() {
+  function init(_modelConfig) {
     if (!setInitFlag(_dom)) {
       return this;
     }
@@ -544,7 +550,9 @@ function Multiselect(element) {
     _options = _dom.options || [];
 
     if (_options.length > 0) {
-      _model = new MultiselectModel(_options, _name).init();
+      // Store underlying model so we can expose it externally
+      _model = new MultiselectModel(_options, _name, _modelConfig).init();
+      _config = _modelConfig;
       const newDom = _populateMarkup();
 
       /* Removes <select> element,
@@ -562,6 +570,14 @@ function Multiselect(element) {
     return this;
   }
 
+  /**
+   * Allow external access to the underlying model for integration/customization when used in other applications.
+   * @returns {object} Model
+   */
+  function getModel() {
+    return _model;
+  }
+
   // Attach public events.
   this.init = init;
   this.expand = expand;
@@ -571,11 +587,16 @@ function Multiselect(element) {
   this.addEventListener = eventObserver.addEventListener;
   this.removeEventListener = eventObserver.removeEventListener;
   this.dispatchEvent = eventObserver.dispatchEvent;
+  this.getModel = getModel;
+  this.updateSelections = _updateSelections;
+  this.selectionClickHandler = _selectionClickHandler;
+  this.selectionKeyDownHandler = _selectionKeyDownHandler;
 
   return this;
 }
 
 Multiselect.BASE_CLASS = BASE_CLASS;
-Multiselect.init = () => instantiateAll(`.${BASE_CLASS}`, Multiselect);
+Multiselect.init = (config) =>
+  instantiateAll(`.${BASE_CLASS}`, Multiselect, undefined, config);
 
 export { Multiselect };
diff --git a/packages/cfpb-forms/src/organisms/MultiselectModel.js b/packages/cfpb-forms/src/organisms/MultiselectModel.js
index d9041df5b8..6e36bba3a6 100644
--- a/packages/cfpb-forms/src/organisms/MultiselectModel.js
+++ b/packages/cfpb-forms/src/organisms/MultiselectModel.js
@@ -29,8 +29,9 @@ function stringMatch(x, y) {
  * @param {HTMLOptionsCollection} options -
  *   Set of options from a <select> element.
  * @param {string} name - a unique name for this multiselect.
+ * @param {Object} config - Customization of Multiselect behavior
  */
-function MultiselectModel(options, name) {
+function MultiselectModel(options, name, config) {
   const _options = options;
   const _name = name;
   let _optionsData = [];
@@ -59,7 +60,8 @@ function MultiselectModel(options, name) {
    *   True if the maximum number of options are checked, false otherwise.
    */
   function isAtMaxSelections() {
-    return _selectedIndices.length === MAX_SELECTIONS;
+    const _max = config?.maxSelections || MAX_SELECTIONS;
+    return _selectedIndices.length >= _max;
   }
 
   /**
diff --git a/packages/cfpb-forms/src/organisms/multiselect.less b/packages/cfpb-forms/src/organisms/multiselect.less
index 033f2f1401..fab69972b7 100644
--- a/packages/cfpb-forms/src/organisms/multiselect.less
+++ b/packages/cfpb-forms/src/organisms/multiselect.less
@@ -132,7 +132,7 @@ select.o-multiselect {
       pointer-events: none;
 
       &::after {
-        content: 'Reached maximum of five selections';
+        content: 'Reached maximum number of selections';
       }
     }