Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure button icon #19

Open
swashbuck opened this issue Mar 28, 2024 · 2 comments
Open

Add option to configure button icon #19

swashbuck opened this issue Mar 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Mar 28, 2024

Subject of the enhancement

Currently, the button icon is baked into the less. It would be good to have this as a configurable option named _iconClass.

"_scrollPrompt": {
  "_isEnabled": true,
  "instruction": "Scroll down",
  "_iconClass": "icon-controls-down"
}

The icon class would appear on the .icon element, which also makes it easier when we need to globally replace certain icon types. For example:

.icon-controls-down {
  font-family: 'custom-icon-font';
  .icon-controls-down-custom;
}

While we are making this change, the .icon element should align to other implementations (ex. use a span tag instead of a div).

@swashbuck swashbuck added the enhancement New feature or request label Mar 28, 2024
@swashbuck
Copy link
Contributor Author

@zubairslamdien Can you take this one on since you're working on #12 ? Thanks!

@zubairslamdien
Copy link

That should be fine @swashbuck. I'll try to get to it in the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants