Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Updates for AAT v1 compatibility (fixes #20) #21

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Dec 5, 2024

Fix #20

New

  • Adds AAT v1 schemas
  • Adds global scrollDown string: _globals._extensions._scrollPrompt.scrollDown

Update

  • Documentation updates, PR template typo fix, cleanup properties.schema

@swashbuck swashbuck added the enhancement New feature or request label Dec 5, 2024
@swashbuck swashbuck self-assigned this Dec 5, 2024
@swashbuck swashbuck marked this pull request as ready for review December 5, 2024 22:34
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @swashbuck and global instruction working as expected. I haven't been able to test this in a v1 AAT instance but I ran this through a JSON schema validator and all good.

Not related to this PR as I was able to replicate in Master but I was unable to get the scroll prompt working on the menu. Are you able to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AAT: Assess for supported plugins inclusion
2 participants