Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target branch in the ChangeMergedEvent #1065

Closed
leonid-deriv opened this issue Sep 27, 2023 · 3 comments · Fixed by #1066
Closed

Target branch in the ChangeMergedEvent #1065

leonid-deriv opened this issue Sep 27, 2023 · 3 comments · Fixed by #1066

Comments

@leonid-deriv
Copy link

Hi

why we do not have a target branch in the ChangeMergedEvent. target branch exists in Change event but this is not very handy :(
Can we add a target branch to ChangeMergedEvent?
@morucci
Copy link
Collaborator

morucci commented Sep 27, 2023

Hi,

Thanks for the report, you are right and I see that adding the "branch" filter in the query leads to empty graphs in the web ui. So yes there is a bug here. I can provide a fix soon. Or let me know if you'd like to tackle that issue.

morucci added a commit to morucci/monocle that referenced this issue Sep 29, 2023
@morucci
crawler: Fix target branch field not set on ChangeEvent Docs
a1448ef 
This change fixes an issue that happen when filtering by branch in the
search query then resulting graphs are empty. This was because most
of the graph related metrics computation relies on the ChangeEvent
docs. Adding the missing field fixes that issue.

fix change-metrics#1065
@morucci morucci mentioned this issue Sep 29, 2023
Merged
@mergify mergify bot closed this as completed in #1066 Sep 29, 2023
@leonid-deriv
Copy link
Author

If you can add a target branch in the ChangeMErged event, it will be great.
To tackle this I was thinking of using Kibana and run-time lookup fields but they are only supported in Elastic 8.2... so the question are you planning to update Elastic version soon?

@morucci
Copy link
Collaborator

morucci commented Sep 29, 2023

If you can add a target branch in the ChangeMErged event, it will be great.

The fix adds the target_branch field to all change events including the ChangeMergedEvent. The fix does not bring any upgrade procedure so that means only events docs related to updated or new changes will get the field.

To tackle this I was thinking of using Kibana and run-time lookup fields but they are only supported in Elastic 8.2... so the question are you planning to update Elastic version soon?

We should update it yes. Here is the related issue #1067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crawler: Fix target branch field not set on ChangeEvent Docs morucci/monocle
2 participants
@morucci @leonid-deriv