Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import data not filled correctly #9

Open
kdg3737 opened this issue Apr 11, 2024 · 1 comment
Open

import data not filled correctly #9

kdg3737 opened this issue Apr 11, 2024 · 1 comment

Comments

@kdg3737
Copy link

kdg3737 commented Apr 11, 2024

Hi Chegewara,

I think I found a bug in your fill_import_data method in uspbip.cpp. The idVendor, idProduct and bcdDevice fields are copied over to the 'devlist_data' object instead of 'import_data':

    devlist_data.idVendor = __bswap_16(dev_desc->idVendor);
    devlist_data.idProduct = __bswap_16(dev_desc->idProduct);
    devlist_data.bcdDevice = __bswap_16(dev_desc->bcdDevice);

should be:

    import_data.idVendor = __bswap_16(dev_desc->idVendor);
    import_data.idProduct = __bswap_16(dev_desc->idProduct);
    import_data.bcdDevice = __bswap_16(dev_desc->bcdDevice);

Just thought I'd let you know.

Thanks for making this very useful poc.

Kris

@chegewara
Copy link
Owner

Hi,
its probably just copy/paste bug.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants