Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading SSH keys from X509 certificates ignore things outside of the armor #41

Open
adiroiban opened this issue Oct 16, 2019 · 1 comment

Comments

@adiroiban
Copy link
Member

RIght now, when loading SSH key from X509 cert, the PEM should contain a single object and the armor should be the first thing in the file.

We should relax this to allow for "PEM comments" for example

BagAttribute=bla
---- BEGIN CERTIFICATE ---
TRALA
@adiroiban
Copy link
Member Author

This is not fixed in chevah-keycert .... it is fixed in chevah/server where the config allows multiple PEMs.

I guess that for keycert we should to something similar:

  1. Try loading using Python pem library and detect the type based on what pem tells us.
  2. If nothing is returned by pem ... try to read anything outside of pem armors... this might need an update in pem library... or add custom code in chevah-keycert similar to the code in chevah/server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant