You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When all reviewers have given a PR a positive review, trigger the "needs-merge" command and add the "needs-merge" label, even if no review was requested (was never in "needs-review").
The text was updated successfully, but these errors were encountered:
danuker
changed the title
Handle the "review approved" GitHub trigger
Handle the "review approved" GitHub trigger even without a previous "needs-review"
Dec 20, 2021
In _setApproveChanges, the source of the current_reviewers should be the ticket body; the bug resulted from using the assignees as "people from which a review is still awaited".
Thus, we should query the review-comments of a PR and see who is pending, out of the required reviewers (in the PR text with "reviewers: ").
When all reviewers have given a PR a positive review, trigger the "needs-merge" command and add the "needs-merge" label, even if no review was requested (was never in "needs-review").
Originally posted by @adiroiban in #18 (comment)
The text was updated successfully, but these errors were encountered: