Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hooks server to OAuth GitHub App #29

Open
danuker opened this issue Jan 10, 2022 · 3 comments
Open

Convert hooks server to OAuth GitHub App #29

danuker opened this issue Jan 10, 2022 · 3 comments

Comments

@danuker
Copy link
Contributor

danuker commented Jan 10, 2022

We might want to convert the current GitHub hooks server to a GitHub App in order to:

  • not require a personal token
  • set up permissions for our hook server via the GitHub UI
  • gain some knowledge about OAuth apps (secondary goal).
  • maybe improve stability (since 50% of issues from Investigate hook failures #54 were due to Azure, not the script). But this is also addressable in Convert hooks server to PythonAnywhere? #56. That and this ticket might not be mutually exclusive.

In the future we will need to add support for OAuth in SFTPPlus server itself.

@danuker danuker added the low label Jan 10, 2022
@adiroiban
Copy link
Member

The main reason to add a GitHub App is to not require a personal token and to set up permissions for our hook server via the GitHub UI :)

For example, we now use the chevah-robot personal API key which has no access to non Chevah Org repos

@danuker
Copy link
Contributor Author

danuker commented Jun 15, 2023

Had to redeploy for updating the token. I think this ticket should no longer be low priority, but medium.

@adiroiban
Copy link
Member

well... top priority is getting our code base to py3 :) everything else is low for now :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants