Issue management - Remove needs-review label when issue is solved

[adiroiban]

We sometimes use an issue to track the progress of a task, without using a PR.

For example the issue is about changing a DNS entry and we don't yet have DNS as a code :)

In this case, we use "needs-review" and "needs-changes" marker directly on an issue and not on a PR.

Sometimes the ticket is in needs-review and the issue is fixed so you want to close this ticket right away.

In this case, you leave a comment to the issue and then press the "comment+close" button

In the comment message we can have something like this

Thanks for the changes. Work great.

issue-fixed

or

Thanks. We no longer need this.

issue-wontfix

or

I don't think that this is a valid issue. This is the documented behavirour.

issue-invalid

so based on the marker in the closing comment, the "needs-review" label is removed and the resolution label is added.

[adiroiban]

I think that in the future GitHub will add a feature to close a ticket as solved or unsolved.

This is why they have change the color for a closed ticket from red to purple :)

As many people were thinking as an red closed issue as something that is not solved.