Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger needs-review on converting a draft PR to a real PR #32

Open
danuker opened this issue Feb 4, 2022 · 1 comment
Open

Trigger needs-review on converting a draft PR to a real PR #32

danuker opened this issue Feb 4, 2022 · 1 comment
Assignees
@danuker
Labels
low

Comments

@danuker
Copy link
Contributor

danuker commented Feb 4, 2022 •
edited
Loading

When a draft PR is marked as ready for review, a pull_request event is emitted with the action ready_for_review.

event: pull_request
content: {'action': 'ready_for_review', 'number': 21, 'pull_request': {...

For example, here, the system failed to react. It should trigger a "needs-review" response.

This may or may not be handled by #18.
@danuker danuker self-assigned this Feb 4, 2022
@adiroiban adiroiban added the low label Jul 10, 2022
@adiroiban
Copy link
Member

I think that this is nice to have...but low priority.

@adiroiban adiroiban mentioned this issue Jul 11, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danuker danuker

Labels
low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danuker @adiroiban