Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle issues also, not just PRs #41

Open
danuker opened this issue Apr 8, 2022 · 0 comments
Open

Handle issues also, not just PRs #41

danuker opened this issue Apr 8, 2022 · 0 comments
Labels

Comments

@danuker
Copy link
Contributor

danuker commented Apr 8, 2022

An issue should be handled correctly also:

https://github.com/chevah/salt-master/issues/1940#issuecomment-1092877637

Right now, only PRs are handled.

Log before deploying #43 :

File "/home/site/wwwroot/chevah/github_hooks_server/handler.py", line 204, in issue_comment
pull_url = event.content['issue']['pull_request']['html_url']
KeyError: 'pull_request'

After #43, and as per the last paragraph of #44, we will need to track "reviewers" of issues via the "Assignees" field again (as before that PR).

@danuker danuker added the low label Apr 8, 2022
@danuker danuker mentioned this issue Aug 18, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant