Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when reviewers marker is missing #42

Open
danuker opened this issue Apr 8, 2022 · 1 comment
Open

Handle case when reviewers marker is missing #42

danuker opened this issue Apr 8, 2022 · 1 comment
Labels

Comments

@danuker
Copy link
Contributor

danuker commented Apr 8, 2022

When a PR/issue has no reviewers specified in the description, the hook should just update the status, not the assignees. request review from the configured default.

@danuker danuker added the low label Apr 8, 2022
@danuker danuker changed the title Handle case when reviewers marker Handle case when reviewers marker is missing Apr 8, 2022
@adiroiban adiroiban added high and removed low labels Jul 10, 2022
@adiroiban
Copy link
Member

I think that the important functionality here is that when no "reviewers" marker is found the robot should fallback to a repo or organization default list of reviewers.


Yes, you can't assign to a team, so you not try.
But what you can do, is that instead of assigning the PR to a person, you should request a review from a person or a team.


The current "assignment" behaviour is from the old times when there was no concept of "reviewer" for a PR.

At the beginning of GitHub, I think that even inline comments were missing.
You only had the general comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants