Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why review request was not triggered #49

Open
danuker opened this issue Dec 9, 2022 · 2 comments
Open

Investigate why review request was not triggered #49

danuker opened this issue Dec 9, 2022 · 2 comments
Assignees
@danuker
Labels
bug low

Comments

@danuker
Copy link
Contributor

danuker commented Dec 9, 2022

On my request of my own review, the other reviewers were not requested. Check out why.

https://github.com/chevah/server/pull/6000#event-7998887813
@danuker danuker self-assigned this Dec 9, 2022
@danuker danuker added the bug label Dec 9, 2022
@adiroiban
Copy link
Member

I guess this is ok.

If you request a review, you are supposed to be the PR driver, so in theory, you have already reviewed the PR before requesting a review from others.

@danuker danuker added the low label Dec 14, 2022
@danuker
Copy link
Contributor Author

danuker commented Dec 14, 2022

All right. I will look at it at Horse's Easter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danuker danuker

Labels
bug low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danuker @adiroiban