Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-request review from others after one reviewer wanted more changes then approved #52

Open
danuker opened this issue Jan 20, 2023 · 1 comment
Open

Re-request review from others after one reviewer wanted more changes then approved #52

danuker opened this issue Jan 20, 2023 · 1 comment
Assignees
@danuker
Labels
bug

Comments

@danuker
Copy link
Contributor

danuker commented Jan 20, 2023

When a reviewer asks for changes, the other review requests are removed.

Later, if that reviewer approves the PR without the branch driver requesting a re-review, currently the hooks server says "needs-merge". But it should request the other reviews instead.
@danuker danuker added the bug label Jan 20, 2023
@danuker danuker self-assigned this Jan 20, 2023
@danuker
Copy link
Contributor Author

danuker commented Jan 20, 2023

May be related to #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danuker danuker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danuker