-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twisted workflow addition: "I accept the review" #55
Comments
So the requirement is something like this.
|
Ok. So it looks like non-team member can do a review ... but maybe that review from a non-team member is not accepted by the branch protection... which I hope it's the case |
Branches should be protected - not a lot of people can commit to a repository; unless maybe auto-merge is enabled. chevah-robot will not merge anything by itself. Whoever has merge access could check, and "I accept the review" could mean the same as the act of merging. Is that adequate?
If the above solution is good enough, then I think this is what's left of this ticket. It would be nice to get a message that the approval was from someone outside the contributor team. |
I guess if we move into the "needs-merge" state, reviewers should be checking that queue as well |
Before we fully migrated to Github in the Tracocalypse, we had an additional process rule: any contributor with commit access could accept a passing review from someone outside the project, if they deemed that the reviewer in question was operating in good faith and following the process sufficiently that it should count.
The main thing we need members of the project to do is code review, so getting this practice and earning this trust gradually from project members seems like an important step to me and it's weird that Github doesn't have something built-in. Anyway.
Right now, a few admins (mostly just me, probably) still follow this part of the process by using the admin-only red merge button, but it would be nice if the robot could understand the magic phrase "I accept the review" to get an official passing checkmark from the robot iff there is a grey checkmark review (passing from non-member).
The text was updated successfully, but these errors were encountered: