Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#58)(#68)(#69) choco-theme 0.6.0 #70

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

st3phhays
Copy link
Member

Description Of Changes

  • Updates Bootstrap to 5.3.x
  • Upgrades Yarn to 4.1.x
  • Removes Gulp
  • Updates the theme toggle to a dropdown, and includes an auto detection option

Motivation and Context

All the changes were done to improve the build process of choco-theme and reduce the chances of security vulnerabilities.

Testing

  1. Preview this website
  2. Use the new theme toggle dropdown and ensure the color modes change correctly
  3. Go through the website and ensure that nothing "looks" or functions differently than on the live site.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed.
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

All issues will be closed in choco-theme which will then close issues here.

This removes Gulp and introduces a number of new
technologies. The build process is now handled by
esbuild, SASS, and a number of new technologies.
Instead of running `gulp` to compile assets, the
command `yarn run choco-theme` is now used. By
running this, all necessary files are put in place
and CSS is purged.
This upgrades Bootstrap to 5.3.x. A large effort
was made to update choco-theme to use Bootstraps
css variables and dark mode settings. This will
help future upgrades to Bootstrap and choco-theme.

This also adds new social media icons and adjusts
old ones.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but can't run site :-(

Choco-theme and any projects that use choco-theme
will now use Yarn 4.1.x. This upgrade will reduce
security vulnerabilities and improve performance.
@st3phhays st3phhays requested a review from gep13 April 11, 2024 16:24
@st3phhays st3phhays marked this pull request as ready for review April 11, 2024 16:24
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit aa07984 into chocolatey:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants