Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Boxstarter specific parameters to make them clearer #444

Open
mwallner opened this issue Oct 13, 2020 · 0 comments
Open

Refactor Boxstarter specific parameters to make them clearer #444

mwallner opened this issue Oct 13, 2020 · 0 comments
Assignees
@mwallner
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features

Comments

@mwallner
Copy link
Member

mwallner commented Oct 13, 2020 •
edited
Loading

What You Are Seeing?

if (@("-RebootCodes", "--RebootCodes") -contains $a) {

vs

if (@("-StopOnPackageFailure", "--StopOnPackageFailure" -contains $a))

take a close look at the closing brackets

this works.. due to PowerShell magic, but really should be cleaned up.

What Is Expected?

be concise!
(talking to myself)
@mwallner mwallner added the Bug Issues where something has happened which was not expected or intended label Oct 13, 2020
@mwallner mwallner self-assigned this Oct 13, 2020
@mwallner mwallner changed the title Boxstarter exlusive params are passed to Chocolatey Boxstarter exclusive params are passed to Chocolatey Oct 13, 2020
mwallner added a commit to mwallner/boxstarter that referenced this issue Oct 13, 2020
@mwallner
chocolateyGH-444 do not pass StopOnPackageFailure to choco
648a36c
@mwallner mwallner mentioned this issue Oct 13, 2020
Merged
9 tasks
@mwallner mwallner added Improvement Issues that enhances existing functionality, or adds new features and removed Bug Issues where something has happened which was not expected or intended labels Oct 13, 2020
@mwallner mwallner changed the title Boxstarter exclusive params are passed to Chocolatey inconcise code - handling of 'Boxstarter exclusive parameters' Oct 13, 2020
@mwallner mwallner changed the title inconcise code - handling of 'Boxstarter exclusive parameters' bad code - handling of 'Boxstarter exclusive parameters' Oct 13, 2020
@pauby pauby changed the title bad code - handling of 'Boxstarter exclusive parameters' Refactor Boxstarter specific parameters to make them clearer Oct 14, 2020
@pauby pauby added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Oct 14, 2020
pauby added a commit that referenced this issue Oct 14, 2020
@pauby
Merge pull request #445 from mwallner/GH-444
8459d49 
(GH-444) Refactor code around Boxstarter specific parameters to make it clearer
HolisticDeveloper pushed a commit to HolisticDeveloper/boxstarter that referenced this issue Oct 18, 2021
Merge branch 'master' of https://github.com/HolisticDeveloper/boxstarter
5f6559a 


* 'master' of https://github.com/HolisticDeveloper/boxstarter: (58 commits)
  Update chocolatey uninstall url
  Fix chocolatey links
  (chocolateyGH-446) Updates documentation with important info
  (chocolateyGH-443) Adds Windows Explorer item check box view Even though Boxstarter has existing functionality to modify Windows Explorer's settings, the existing functionality did not allow for user's to configure the "Use check boxes to select items" setting.  This commit adds that functionality to the existing set-windowsexploreroptions function.
  (chocolateyGH-451) more accurate regex
  (chocolateyGH-451) StopOnPackageFailiure not stripped without RebootCodes
  (release v2.13.0) Updated version numbers
  chocolateyGH-444 do not pass StopOnPackageFailure to choco
  Merge pull request from GHSA-rpgx-h675-r3jf
  (chocolateyGH-405) Fix package parameter handling (chocolatey#412)
  (chocolateyGH-434) Fix disabling bing search for Win release 2004+ (chocolatey#438)
  chocolateygh-435 docs for DelegateChocoSources
  (build) Replace direct usage of cinst
  (build) Pin all packages to specific version
  (build) Remove deprecated package
  (build) Make project files consistent
  (build) Pin to specific version of nuget.commandline
  (build) Remove VS import for web targets
  (build) Trying to fix AppVeyor build
  (doc) Update template
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwallner mwallner

Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwallner @pauby