Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation black/white reversal in Singles #664

Closed
wants to merge 1 commit into from

Conversation

kurahaupo
Copy link

@kurahaupo kurahaupo commented Jun 25, 2024

Remove "black" and "white" because they're inverted when using a dark/nighttime theme (would fix #663 ...)

Remove "black" and "white" because they're inverted when using a dark/nighttime theme
@chrisboyle
Copy link
Owner

Thanks for this; unfortunately I cannot merge it in its current form:

  • The HTML files are generated from puzzles.but using halibut, and the only reason they're checked in is so that developers working on anything other than docs don't need to install halibut. I keep meaning to tweak the generation process to insert a big warning comment at the top of the HTML explaining this, but haven't yet, sorry.
  • While the change for Singles is small enough, this should probably be addressed coherently for all 40 puzzles at once, and many of the others are harder to describe in a colour-agnostic way.
  • I don't want to make that level of change to the docs source as an Android-specific change, because it will impede all future merges from upstream that touch the docs.

There is light at the end of the tunnel though: Simon has mentioned wanting to add colour preferences upstream, at which point I imagine he would do something to make the docs more colour-agnostic, and then any smaller Android tweaks can be made starting from that point.

@chrisboyle chrisboyle closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation black/white reversal
2 participants