Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you like to contribute this to prestosql as part of kafka plugin? #2

Open
kokosing opened this issue Oct 13, 2020 · 2 comments
Open

Comments

@kokosing
Copy link

This project seems to bring great value. Having this as part of PrestoSql project would make sure it would be widely used and maintained by vibrant Presto community.

What do you think?

@drowoseque
Copy link
Collaborator

Hey @kokosing
I don't think this logging plugin should be embedded into the Kafka plugin, which is responsible for reading data

@kokosing
Copy link
Author

Notice that Presto plugin may provide many features. You don't have to have a single plugin per feature (like connector or event listener).

Having this separate, we will possibly end up with another presto and kafka related library that would be used by two separate Kafka plugins in Presto. Having this both in one place is much easier.

Additionally, notice io.prestosql.spi.connector.Connector#getEventListeners. So could possibly configure kafka plugin to provide both features to Presto at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants