Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make harvard-university-of-worcester.csl a dependent of CTR12 #7051

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented May 14, 2024

Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@POBrien333 POBrien333 changed the title Update harvard-university-of-worcester.csl Make harvard-university-of-worcester.csl a dependent of CTR12 May 14, 2024
Copy link

😟 There are some issues with your submission.

2 tests failed

harvard-university-of-worcester: must be an independent style (dependent styles must be placed in the "dependent" subdirectory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" default-locale="en-GB" children=[1]>.independent?` to be truthy, got false

harvard-university-of-worcester: must have a "class" attribute that matches the "citation-format" attribute

expected: "in-text"
     got: nil

(compared using ==)

Please check the test report for details.

Copy link

😟 There are some issues with your submission.

1 test failed

harvard-university-of-the-west-of-england: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "harvard-university-of-worcester"

Please check the test report for details.

@kat-devine76
Copy link

Hi, I'm the person who originally made the request on the Zotero forum. Is there a way of getting the University of Worcester Harvard style completely removed from here? Thank you! (P.S. I'm a librarian, not a developer, so please treat me like the complete novice I am!)

@adam3smith
Copy link
Member

@POBrien333 could you fix the template in the west england style? That's the reason the test failed in May (it'll also fail now, but you can ignore that)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 29, 2024
@POBrien333
Copy link
Contributor Author

@adam3smith Thanks. That should be fixed now

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 29, 2024
@adam3smith adam3smith merged commit 785c6ef into citation-style-language:master Nov 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants