Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No MessageID and MessageContent in ReadPublicationResponse for non-Json content #1

Open
mattys101 opened this issue Oct 5, 2022 · 0 comments

Comments

@mattys101
Copy link

Hello,
I think I found a little bug with the publication and read of the messages when non-Json content is provided for the message content while trying to do a simple test by just sending a string (which is still technically JSON). For example,

producer.PostPublication(ServerUrl, SessionID, Topic, "\"A test message\"");

Basically, if non-Json content is used it is not written nor read properly.
I assume this is based on the assumption that the content should be a JSON Object and/or the way the JSON library in use handles non-Json content.

Suggested short term fix would be to raise an exception if a non-Json Object is provided or being read, just so that it is clear to the user of the library that it is expected to be a JSON Object.
Long term fix of course would be to support the different content types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant