Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break the single class into several components #44

Open
leandromoreira opened this issue Sep 21, 2017 · 1 comment
Open

Break the single class into several components #44

leandromoreira opened this issue Sep 21, 2017 · 1 comment

Comments

@leandromoreira
Copy link
Member

leandromoreira commented Sep 21, 2017 •
edited
Loading

This abstraction is getting bigger, therefore, I think we should split it, maybe compose it with:

  • DashShakaTracks - deals with tracks behavior
  • DashShakaEvents - deals with _onXXXX
class DashShakaTracks {
  constructor (dashShakaPlayback) {
    this._dashShakaPlayback = dashShakaPlayback;
  }
}
@joaopaulovieira
Copy link
Member

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leandromoreira @joaopaulovieira