Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown buildreqs should be removed from buildreq_cache #480

Open
phmccarty opened this issue Sep 23, 2019 · 0 comments
Open

Unknown buildreqs should be removed from buildreq_cache #480

phmccarty opened this issue Sep 23, 2019 · 0 comments
Labels
bug A defect in autospec's operation

Comments

@phmccarty
Copy link
Contributor

phmccarty commented Sep 23, 2019 •
edited
Loading

If an unknown buildreq is detected for a particular build round, autospec adds that buildreq to buildreq_cache. Autospec should avoid adding the unknown buildreq to buildreq_cache to avoid the need to manually remove it in later autospec runs.

Typically, the user will add the missing buildreq, or buildreq_ban it, so this is not an urgent issue to fix.
@phmccarty phmccarty added the bug A defect in autospec's operation label Sep 23, 2019
@phmccarty phmccarty self-assigned this Jan 11, 2020
phmccarty added a commit to phmccarty/autospec that referenced this issue Jan 11, 2020
@phmccarty
Remove unresolveable dependency names from the buildreq_cache
e2eb255 
The buildreq cache should only contain names/symbols/etc that are
resolvable at build time. The names may indicate missing packages, but
they may also be invalid, so it is best to avoid adding the names to the
cache in the first place.

Fixes clearlinux#480

Signed-off-by: Patrick McCarty <[email protected]>
phmccarty added a commit to phmccarty/autospec that referenced this issue Jan 11, 2020
@phmccarty
Remove unresolvable dependency names from the buildreq_cache
9d5b527 
The buildreq cache should only contain names/symbols/etc that are
resolvable at build time. The names may indicate missing packages, but
they may also be invalid, so it is best to avoid adding the names to the
cache in the first place.

Fixes clearlinux#480

Signed-off-by: Patrick McCarty <[email protected]>
phmccarty added a commit to phmccarty/autospec that referenced this issue Jan 11, 2020
@phmccarty
Remove unresolvable names from buildreq_cache
182dc05 
The buildreq cache should only contain names/symbols/etc that are
resolvable at build time. The names may indicate missing packages, but
they may also be invalid, so it is best to avoid adding the names to the
cache in the first place.

Fixes clearlinux#480

Signed-off-by: Patrick McCarty <[email protected]>
@phmccarty phmccarty mentioned this issue Jan 11, 2020
Closed
phmccarty added a commit to phmccarty/autospec that referenced this issue Jan 13, 2020
@phmccarty
Remove unresolvable names from buildreq_cache
b81a1eb 
The buildreq cache should only contain names/symbols/etc that are
resolvable at build time. The names may indicate missing packages, but
they may also be invalid, so it is best to avoid adding the names to the
cache in the first place.

If the name is only present in the cache, retry the build. Any presence
of the name in buildreq_add will halt the build.

Fixes clearlinux#480

Signed-off-by: Patrick McCarty <[email protected]>
@phmccarty phmccarty removed their assignment Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in autospec's operation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unresolvable names from buildreq_cache phmccarty/autospec
1 participant
@phmccarty