Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan_for_configure rework needed for archive layout changes #589

Open
phmccarty opened this issue Mar 11, 2020 · 0 comments
Open

scan_for_configure rework needed for archive layout changes #589

phmccarty opened this issue Mar 11, 2020 · 0 comments
Labels
bug A defect in autospec's operation refactor-needed Refactoring needed to fix issue or implement feature

Comments

@phmccarty
Copy link
Contributor

phmccarty commented Mar 11, 2020

The fix for scan_for_configure in #497 had the desired outcome, but it also produced negative side effects due to the current layout of the tmp directory where archives are extracted. Namely, if a package ships archives, and one or more of those archives provide their own configure scripts, cmake files, etc, needed for the package build, then autospec won't scan them.

The package I'm currently looking at with broken buildreq detection is ParaView. It has multiple archives, and the archive extracted to the VTK directory provides cmake files for the main package.

@phmccarty phmccarty added the bug A defect in autospec's operation label Mar 11, 2020
@phmccarty phmccarty added the refactor-needed Refactoring needed to fix issue or implement feature label Apr 15, 2020
clrpackages pushed a commit to clearlinux-pkgs/pytorch that referenced this issue May 4, 2020
This dependency is obsolete since Python 3.5.

Also, declare deps on `onnx` and `opcodes` manually, since autodetection
is currently broken, likely due to
clearlinux/autospec#589.

(The dependencies are from archive tarballs, not the primary one.)

Signed-off-by: Patrick McCarty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in autospec's operation refactor-needed Refactoring needed to fix issue or implement feature
Projects
None yet
Development

No branches or pull requests

1 participant