Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NoSchedule taint data in system information in metrics report rather than reporting it repeatedly #219

Open
dklyle opened this issue Oct 12, 2019 · 1 comment
Labels
enhancement New feature or request scaling

Comments

@dklyle
Copy link
Contributor

dklyle commented Oct 12, 2019

The system config data in the json files already contains the NoSchedule taint information. This information does not change during a test run. Use the system config information rather than repeatedly reporting the NoSchedule taint per node, per iteration. This will avoid unnecessary overhead of making execs to the stats pods.

@dklyle dklyle added enhancement New feature or request scaling labels Oct 12, 2019
@dklyle dklyle self-assigned this Oct 12, 2019
@dklyle dklyle changed the title use NoSchedule taint in system information in report rather than reporting it repeatedly use NoSchedule taint data in system information in metrics report rather than reporting it repeatedly Oct 12, 2019
@dklyle
Copy link
Contributor Author

dklyle commented Oct 19, 2019

I'm actually inclined to leave this as is for the k8s_scale.sh, it's fixed in k8s_scale_rapid.sh, but the node information is used in the k8s_scale.sh as well. While it would be possible to extract it. I'm not sure the overall benefit is worth it at this point.

@dklyle dklyle removed their assignment Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scaling
Projects
None yet
Development

No branches or pull requests

1 participant