Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require a tag to function #9

Open
vilmibm opened this issue Dec 3, 2021 · 3 comments
Open

Do not require a tag to function #9

vilmibm opened this issue Dec 3, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@vilmibm
Copy link
Contributor

vilmibm commented Dec 3, 2021

While it's ok to continue defaulting to running on a tag push, this extension should function without a tag and just use HEAD if run via a generic push or a workflow run trigger. (see discussion in #2 (comment) )

@vilmibm vilmibm added the help wanted Extra attention is needed label Dec 3, 2021
@jef
Copy link

jef commented Sep 28, 2022

I think it does now: https://github.com/cli/gh-extension-precompile/blob/trunk/build_and_release.sh#L21-L25

Probably can be closed now! :)

@bewuethr
Copy link
Contributor

bewuethr commented Dec 20, 2022

The solution for this implemented in #21 breaks when the most recent tag is not on the commit that's checked out, and the checkout is shallow (which is the default behaviour of actions/checkout); this should probably be documented?

@mislav
Copy link
Contributor

mislav commented Dec 21, 2022

This wasn't solved; that's the reason this issue is still open. Pushing a git tag is still required for this action to function.

The idea is that it might be useful for this action to also have utility when activated on push to a branch or on a workflow_dispatch event. However, that would still mean that the compiled assets need to be stored somewhere, and that somewhere should be a Release, and Releases can only ever be attached to git tags. Therefore, this action should gain the ability to auto-increment a version number in order to generate new git tags when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants
@mislav @vilmibm @bewuethr @jef and others