CLI should not depend on rustup #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
force-pushed
the
mamcx/no_rustup_cli
branch
from
5918c82
to
0156bba
Compare
kazimuth
reviewed
Nov 15, 2024
RReverser
reviewed
Nov 16, 2024
RReverser
reviewed
Nov 16, 2024
mamcx
force-pushed
the
mamcx/no_rustup_cli
branch
from
0156bba
to
f820488
Compare
RReverser
reviewed
Nov 19, 2024
RReverser
reviewed
Nov 19, 2024
bfops
reviewed
Nov 22, 2024
bfops
reviewed
Nov 22, 2024
|
Looks basically good to me, two small comments |
mamcx
force-pushed
the
mamcx/no_rustup_cli
branch
from
39bcb5f
to
d22b6f9
Compare
RReverser
reviewed
Nov 22, 2024
bfops
reviewed
Nov 25, 2024
bfops
reviewed
Nov 25, 2024
mamcx
force-pushed
the
mamcx/no_rustup_cli
branch
from
51a7e8a
to
d83b9ae
Compare
mamcx
force-pushed
the
mamcx/no_rustup_cli
branch
from
d83b9ae
to
10541e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rustup could not be installed (for example, for people who use
nix).Now, the
clidefensively check for it. It also try to find the targetwasm32-unknown-unknownin case is not installed.Closes #1971.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!