-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI testing for VM/CNV #263
Comments
@dry923 Just FYI, if you add CNV to the CI environment, we can run fio inside CNV VMs, that's already supported (except for issue 527 which I haven't had time to work on, but it has an easy fix described there). |
Hey @bengland2 The hope would be we increase the coverage of SNAFU to cover, BM, VM, Container (Podman/docker), OCP... |
+1 for VM/CNV testing, but we should probably look at moving away from |
Issue #261 was caused because of missing init file in the log_wrapper directory. It would still fail on outside of openshift (ie VMs, etc) without that file. benchmark-wrapper is installed as a python package and directories without init file are not included in the package. Benchmark-wrapper CI uses benchmark-operator, the test for log_wrapper were not merged at that moment, else our CI would have found this issue. @sarahbx Another way to install benchmark-wrapper is |
Hi @amitsagtani97 :) For VMs in benchmark-operator, we are using
|
@learnitall I wonder how your staged CI would mitigate the need for this? |
Spawning this issue from #261 which was caused because we did not test on anything outside of openshift (ie VMs, etc).
We currently do not have a method of CI testing CNV/VM's for benchmark-wrapper. As we continue to move forward this is something we should look into as it will likely become more prevelant.
cc: @sarahbx @jtaleric @amitsagtani97
The text was updated successfully, but these errors were encountered: