Index benchmark metadata #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
|
/rerun all |
|
LGTM! |
Signed-off-by: Raul Sevilla <[email protected]>
|
/rerun all kube-burner:WORKLOAD=cluster-density ./run.sh |
|
Results for e2e-benchmarking CI Tests
|
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
|
/rerun all |
|
Results for e2e-benchmarking CI Tests
|
Signed-off-by: Raul Sevilla <[email protected]>
|
/rerun all |
Sure, I was going nuts cuz I couldn't find any document :D |
|
Results for e2e-benchmarking CI Tests
|
|
/rerun all kube-burner:WORKLOAD=max-namespaces ./run.sh |
|
Results for e2e-benchmarking CI Tests
|
| @@ -177,15 +178,16 @@ local METADATA=$(cat << EOF | |||
| "total_nodes":"${TOTAL_NODES}", | |||
| "sdn_type":"${SDN_TYPE}", | |||
| "benchmark":"${BENCHMARK}", | |||
| "start_date":"${START_DATE}", | |||
| "timestamp":"${START_DATE}", | |||
There was a problem hiding this comment.
why are we changing this?
There was a problem hiding this comment.
We generally use timestamp as date field in our indexes and grafana is only able to handle a time field (Except for uperf which is uperf_ts, that's something we'll have to change to stantarize)
There was a problem hiding this comment.
ohh right yeah, this was added recently
Signed-off-by: Raul Sevilla <[email protected]>
|
/rerun all |
|
Results for e2e-benchmarking CI Tests
|
|
LGTM |
vishnuchalla
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Index benchmark metadata Signed-off-by: Raul Sevilla <[email protected]> * Add check for workload nodes Signed-off-by: Raul Sevilla <[email protected]> * Add informative log Signed-off-by: Raul Sevilla <[email protected]> * Fix delete CR Signed-off-by: Raul Sevilla <[email protected]> * Set static index variable Signed-off-by: Raul Sevilla <[email protected]> * Timestamp must be on milliseconds Signed-off-by: Raul Sevilla <[email protected]> * Send node count as integer Signed-off-by: Raul Sevilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raul Sevilla [email protected]
Description
Index benchmark metadata leveraging the run_benchmark helper. Some benchmarks such as router-perf does not use that wrapper, we'll have to implement this functionallity separately.
Also renaming the start_date to the common timestamp field
Fixes