Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event does not have new method #207

Open
xiaoas opened this issue Mar 8, 2023 · 1 comment
Open

Event does not have new method #207

xiaoas opened this issue Mar 8, 2023 · 1 comment

Comments

@xiaoas
Copy link
Contributor

xiaoas commented Mar 8, 2023

Users expect to use Event::new() to construct a event.
According to API guideline: https://rust-lang.github.io/api-guidelines/predictability.html

  • we should implement Event::new()
  • we should revise the doc to encourage the use of Event::new()`
@ozabalaferrera
Copy link
Contributor

I believe this is intentional. Instead, the builder pattern is used to force compliance with the different CloudEvent Spec versions (0.3 and 1.0). It aligns with this note in the API guidelines:

If your type has a multiplicity of construction options though, consider the builder pattern (C-BUILDER) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants