Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve syntax of scripts using linters #27

Open
root360-AndreasUlm opened this issue Nov 25, 2019 · 0 comments
Open

improve syntax of scripts using linters #27

root360-AndreasUlm opened this issue Nov 25, 2019 · 0 comments

Comments

@root360-AndreasUlm
Copy link

Hi,

I reviewed the scripts used by flan.
The linters of the used scripting languages report some issues which might also lead to unexpected behaviours.

As linters I used:

  • shellcheck for run.sh
  • pylint for *.py (ignoring missing-docstring & invalid-name)

I'll open PR for every script to fix the syntax.
That way linting could be added to a CI/CD job which is testing changes for new releases.

Regards,
Andreas
@root360-AndreasUlm root360-AndreasUlm mentioned this issue Nov 25, 2019
Open
root360-AndreasUlm added a commit to root360/flan that referenced this issue Nov 25, 2019
@root360-AndreasUlm
fixed syntax of aws_push.py based on pylint
eaba4e0 
Fixed issues reported by pylint as part of
cloudflare#27.

Signed-off-by: Andreas Ulm <[email protected]>
@root360-AndreasUlm root360-AndreasUlm mentioned this issue Nov 25, 2019
Closed
root360-AndreasUlm added a commit to root360/flan that referenced this issue Nov 25, 2019
@root360-AndreasUlm
Fixed issues reported by pylint as part of cloudflare#27.
d2fd016 
Signed-off-by: Andreas Ulm <[email protected]>
@root360-AndreasUlm root360-AndreasUlm mentioned this issue Nov 25, 2019
Closed
root360-AndreasUlm added a commit to root360/flan that referenced this issue Nov 25, 2019
@root360-AndreasUlm
fixed syntax of output_report.py based on pylint
385f458 
Fixed issues reported by pylint as part of
cloudflare#27.

Signed-off-by: Andreas Ulm <[email protected]>
@root360-AndreasUlm root360-AndreasUlm mentioned this issue Nov 25, 2019
Closed
root360-AndreasUlm added a commit to root360/flan that referenced this issue Nov 25, 2019
@root360-AndreasUlm
fixed syntax based on shellcheck
4a40270 
Fixed issues reported by shellcheck
(https://github.com/koalaman/shellcheck/wiki) to improve security and
POSIX shell interoperability.

(part of cloudflare#27)

Signed-off-by: Andreas Ulm <[email protected]>
root360-AndreasUlm added a commit to root360/flan that referenced this issue Nov 28, 2019
@root360-AndreasUlm
fixed syntax of output_report.py based on pylint
db0b446 
Fixed issues reported by pylint as part of
cloudflare#27.

Signed-off-by: Andreas Ulm <[email protected]>
root360-AndreasUlm added a commit to root360/flan that referenced this issue Mar 12, 2020
@root360-AndreasUlm
fixed syntax based on shellcheck
aaf0e38 
Fixed issues reported by shellcheck
(https://github.com/koalaman/shellcheck/wiki) to improve security and
POSIX shell interoperability.

(part of cloudflare#27)

Signed-off-by: Andreas Ulm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@root360-AndreasUlm