We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi !
Sorry I'm new to working with github (coming from bitbucket) and open source projects.
I'm unsure what the correct approach is to make a PR with a bugfix :) (please correct me / tell me the right approach to contributing)
I had a an error in the subtractone example. Which was fixed by cd
cd /gui npm i @tonaljs/tonal
error:
ERROR in ./src/actions/actions.js 4:0-48
Module not found: Error: Can't resolve '@tonaljs/tonal' in 'C:\repos\cmajor\examples\cmajor\examples\patches\SubtractOne\gui\src\actions'
suggested fix: package.json: ... "dependencies": { "@tonaljs/midi": "^3.3.1", "@tonaljs/tonal": "^4.10.0", "framer-motion": "^1.6.7", "react": "^16.9.0", "react-dom": "^16.9.0", "react-redux": "^7.1.1", "react-scripts": "^5.0.1", "styled-components": "^4.4.0", "tonal": "^2.2.2" }, ..
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi !
Sorry I'm new to working with github (coming from bitbucket) and open source projects.
I'm unsure what the correct approach is to make a PR with a bugfix :) (please correct me / tell me the right approach to contributing)
I had a an error in the subtractone example. Which was fixed by cd
error:
ERROR in ./src/actions/actions.js 4:0-48
Module not found: Error: Can't resolve '@tonaljs/tonal' in 'C:\repos\cmajor\examples\cmajor\examples\patches\SubtractOne\gui\src\actions'
suggested fix:
package.json:
...
"dependencies": {
"@tonaljs/midi": "^3.3.1",
"@tonaljs/tonal": "^4.10.0",
"framer-motion": "^1.6.7",
"react": "^16.9.0",
"react-dom": "^16.9.0",
"react-redux": "^7.1.1",
"react-scripts": "^5.0.1",
"styled-components": "^4.4.0",
"tonal": "^2.2.2"
},
..
The text was updated successfully, but these errors were encountered: