Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtract one example missing tonal package :) #79

Open
LasseMunk opened this issue Sep 25, 2024 · 0 comments
Open

subtract one example missing tonal package :) #79

LasseMunk opened this issue Sep 25, 2024 · 0 comments

Comments

@LasseMunk
Copy link

LasseMunk commented Sep 25, 2024

Hi !

Sorry I'm new to working with github (coming from bitbucket) and open source projects.

I'm unsure what the correct approach is to make a PR with a bugfix :) (please correct me / tell me the right approach to contributing)

I had a an error in the subtractone example. Which was fixed by cd

cd /gui 
npm i @tonaljs/tonal

error:

ERROR in ./src/actions/actions.js 4:0-48

Module not found: Error: Can't resolve '@tonaljs/tonal' in 'C:\repos\cmajor\examples\cmajor\examples\patches\SubtractOne\gui\src\actions'

suggested fix:
package.json:
...
"dependencies": {
"@tonaljs/midi": "^3.3.1",
"@tonaljs/tonal": "^4.10.0",
"framer-motion": "^1.6.7",
"react": "^16.9.0",
"react-dom": "^16.9.0",
"react-redux": "^7.1.1",
"react-scripts": "^5.0.1",
"styled-components": "^4.4.0",
"tonal": "^2.2.2"
},
..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant