Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Incorporate Enclosure plugin info #85

Open
tankdeer opened this issue Feb 3, 2022 · 2 comments
Open

[Feature Request] Incorporate Enclosure plugin info #85

tankdeer opened this issue Feb 3, 2022 · 2 comments

Comments

@tankdeer
Copy link

tankdeer commented Feb 3, 2022

First off, awesome plugin. Thanks.

I, like many, am using the Enclosure plugin to control, in my case, several LEDs controlled by GPIO pins on the pi. I have a couple manually created MQTT lights in Home Assistant that allow me to control them by publishing Gcode commands to octoPrint/hassControl/commands, and it works ok. The problem is, there is no topic to subscribe to to get the state, so the state is always "optimistic", which is not ideal. Additionally, Gcode commands are only processed when connected to the printer, but most of my lights don't rely on a printer connection

I know you've done similar with other plugins, so if it's possible to incorporate the information from Enclosure as well, that would be awesome.

It doesn't necessarily need to have discovery enabled, as I realize there are a lot of different configuration options with Enclosure, so it might not be practical to have lights/fans created automatically, and that's fine. If there's a state topic for each configured GPIO, I would think that might be enough for everybody to configure lights/fans/etc in Home Assistant as needed. (Though I am no expert)

Cheers

@cmroche
Copy link
Owner

cmroche commented Apr 23, 2022

It's an interesting idea, but I think it would require some kind of configuration in the plugin too to decide which GPIO states to update since it's hard to know what is connected and could results in a lot of messages over MQTT if say one of those pins was a data pin for instance.

@tankdeer
Copy link
Author

Enclosure has a configuration obviously. In that, you define what each GPIO pin you care about does. I'm not sure if you can read the config of another plugin or not, but if so, that might be an option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants