You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CRDB-specific implentations of Comparer and KeySchema are defined in the CRDB tree, as well as the internal/crdbtest subpackage. It would be ideal to have a single implementation so we don't have to rely on error-prone manual porting of changes.
The current proposal is to move it into a top-level directory inside pebble, along with a linter that disallows importing it from non-test code. CRDB would import it and use it directly.
We have discussed putting it into a third repository, but it adds some unnecessary complications;
the dependency story is not clean (unless we remove all crdb-related test stuff from the pebble repo)
making changes would be harder to synchronize.
bumping the pebble and the third library dependency in CRDB will be more complicated
There is a small hiccup with addressing this issue, related to test-only checks: the CRDB version uses the crdb-specific buildutil.CrdbTestBuild and Pebble is currently never built with the invariant tag as part of the CRDB bazel build. Because of this difficulty, we should aim to do this only on master and leave release-24.3 as is.
The CRDB-specific implentations of
Comparer
andKeySchema
are defined in the CRDB tree, as well as theinternal/crdbtest
subpackage. It would be ideal to have a single implementation so we don't have to rely on error-prone manual porting of changes.The current proposal is to move it into a top-level directory inside
pebble
, along with a linter that disallows importing it from non-test code. CRDB would import it and use it directly.We have discussed putting it into a third repository, but it adds some unnecessary complications;
There is a small hiccup with addressing this issue, related to test-only checks: the CRDB version uses the crdb-specific
buildutil.CrdbTestBuild
and Pebble is currently never built with the invariant tag as part of the CRDB bazel build. Because of this difficulty, we should aim to do this only on master and leave release-24.3 as is.Jira issue: PEBBLE-284
The text was updated successfully, but these errors were encountered: