Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable strict mode for transactions #50

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Sep 23, 2024

Description
This PR ensures that the queue uses the correct connection group defined in the config file and disables strict mode for transactions. Due to the nature of the queue worker (a long-running process), we don't want one failed transaction to affect others.

Needs #49

Fixes: #41

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 12551805825

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.63%

Totals Coverage Status
Change from base Build 12551461905: 0.1%
Covered Lines: 532
Relevant Lines: 587

💛 - Coveralls

@michalsn michalsn marked this pull request as draft December 27, 2024 10:53
@michalsn michalsn marked this pull request as ready for review December 30, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Queue Not Logging Failed Tasks with Transactions
2 participants