Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: header and sidebar data passing logic #521

Merged
merged 1 commit into from
Sep 8, 2023
Merged

refactor: header and sidebar data passing logic #521

merged 1 commit into from
Sep 8, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Sep 8, 2023

Major changes:

  1. refactor the logic of data passing in Header and Sidebar. Most code was introduced in feat: header and sidebar improvement #116
  2. use {children} for passing items into Header. Relevant code introduced in Feat: add a top-right share-button on the repo page #152
  3. move sidebar to the right. This is not meant to be a better UI, but for the ease of implementing the toggling behavior correctly.

Minor changes:

  1. make ui-web/ and ui-desktop/ import styles (App.css and index.css) from ui/
  2. remove max-width, partially fix UI regressions after using Vite #506
  3. remove button:focus styles

@lihebi lihebi merged commit a2dd943 into codepod-io:main Sep 8, 2023
@senwang86 senwang86 mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI regressions after using Vite
1 participant
@lihebi