Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types not properly defined in package.json #17

Open
summer-jordan opened this issue Oct 15, 2024 · 0 comments · May be fixed by #18
Open

Types not properly defined in package.json #17

summer-jordan opened this issue Oct 15, 2024 · 0 comments · May be fixed by #18

Comments

@summer-jordan
Copy link

Issue Description

The typescript types are not resolved when moduleResolution is set to bundler.

This can be confirmed by checking the package with are the types wrong
Screenshot 2024-10-15 at 11 32 04 AM

Proposed Resolution

This issue is resolved by adding a types entry for each of the package.json's exports entries.

I have made the changes locally and confirmed by packing the lib and testing again with arethetypeswrong
Screenshot 2024-10-15 at 11 31 34 AM
@summer-jordan summer-jordan linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add types to package.json exports summer-jordan/responsive-email
1 participant
@summer-jordan