Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add new preferred memory color (PMC) chart. #1269

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Jun 1, 2024

Closes #1267.

Summary

This PR adds the new preferred memory color (PMC) chart from Luo (2024):

import colour
RGB = colour.XYZ_to_sRGB([colour.sd_to_XYZ(sd, illuminant=colour.SDS_ILLUMINANTS["D65"]) / 100 for sd in colour.SDS_COLOURCHECKERS["PMC"].values()])
colour.plotting.plot_multi_colour_swatches(RGB, columns=6, direction="-y")

image

References #1267.

Preflight

Code Style and Quality

  • [N/A] Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.5 milestone Jun 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 99.968%. remained the same
when pulling 693a119 on feature/PMC
into 8e965cf on develop.

@KelSolaar KelSolaar merged commit 835a124 into develop Jun 4, 2024
32 checks passed
@KelSolaar KelSolaar deleted the feature/PMC branch June 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Implement support for *PMC* chart.
2 participants