Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten freetype pin #215

Closed
wants to merge 3 commits into from
Closed

Conversation

grlee77
Copy link
Member

@grlee77 grlee77 commented Apr 4, 2019

closes #214

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Migration

Yes, 2.10 seems to be ABI incompatible with 2.9.1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@grlee77
Copy link
Member Author

grlee77 commented Apr 4, 2019

@conda-forge-admin, please rerender

@grlee77
Copy link
Member Author

grlee77 commented Apr 4, 2019

ping @conda-forge/bot

@grlee77
Copy link
Member Author

grlee77 commented Apr 4, 2019

wasn't sure if I was supposed to also update "version" in meta.yaml here or if that is automated somehow? I didn't look like the other open PRs modified that

@CJ-Wright
Copy link
Member

The bot is currently undergoing some revisions so I'll try to put up a migrator when that is finished.

@isuruf
Copy link
Member

isuruf commented Apr 4, 2019

@grlee77, from the linked issue it was not clear to me whether downgrading to freetype 2.9.1 fixed the issue. Can you confirm?

@grlee77
Copy link
Member Author

grlee77 commented Apr 4, 2019

I did not get a response, but can try it now locally and see if I can replicate the issue

@grlee77
Copy link
Member Author

grlee77 commented Apr 4, 2019

@grlee77, from the linked issue it was not clear to me whether downgrading to freetype 2.9.1 fixed the issue. Can you confirm?

I could not reproduce the issue from conda-forge/vtk-feedstock#80. I tried creating a new virtual env with vtk 8.2 and freetype 2.10.0 . import vtk works fine and so does opening the mayavi2 application. I also tried from a linux system and didn't find problems there either

There were a handful of symbol differences reported between 2.9.1 and 2.10.0. How does one typically judge whether this is likely to be a problem? Sorry if this PR was a false alarm.

Let me know if you want me to remove the change in pinning and still bump the pinned version. Otherwise feel free to close this PR if you do not think we should change the pinning at this time.

@isuruf
Copy link
Member

isuruf commented Apr 4, 2019

How does one typically judge whether this is likely to be a problem?

If the removed symbols look like FT_Outline_Done_Internal, FT_Outline_New_Internal in a mature library then they are probably not of concern.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 10, 2019

@grlee77 and @isuruf should we merge this one or is it OK to keep the current pinning?

@isuruf
Copy link
Member

isuruf commented Apr 10, 2019

I think the current pin is fine. If we can find a bug where the loose pinning is the culprit, we can merge this, but until then I'll leave this PR open.

@grlee77
Copy link
Member Author

grlee77 commented Apr 10, 2019

If you want to close this that is fine. I could not reproduce the issue on the VTK end, but this issue is linked there so we can reopen as needed.

@ocefpaf ocefpaf closed this Apr 10, 2019
maresb pushed a commit to maresb/conda-forge-pinning-feedstock that referenced this pull request Nov 1, 2022
add support for 'packages.conda' section hotfixing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tighten pinning for freetype?
6 participants