-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten freetype pin #215
Tighten freetype pin #215
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2019.03.17
ping @conda-forge/bot |
wasn't sure if I was supposed to also update "version" in meta.yaml here or if that is automated somehow? I didn't look like the other open PRs modified that |
The bot is currently undergoing some revisions so I'll try to put up a migrator when that is finished. |
@grlee77, from the linked issue it was not clear to me whether downgrading to freetype 2.9.1 fixed the issue. Can you confirm? |
I did not get a response, but can try it now locally and see if I can replicate the issue |
I could not reproduce the issue from conda-forge/vtk-feedstock#80. I tried creating a new virtual env with There were a handful of symbol differences reported between 2.9.1 and 2.10.0. How does one typically judge whether this is likely to be a problem? Sorry if this PR was a false alarm. Let me know if you want me to remove the change in pinning and still bump the pinned version. Otherwise feel free to close this PR if you do not think we should change the pinning at this time. |
If the removed symbols look like |
I think the current pin is fine. If we can find a bug where the loose pinning is the culprit, we can merge this, but until then I'll leave this PR open. |
If you want to close this that is fine. I could not reproduce the issue on the VTK end, but this issue is linked there so we can reopen as needed. |
add support for 'packages.conda' section hotfixing
closes #214
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Migration
Yes, 2.10 seems to be ABI incompatible with 2.9.1