Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurations can pick up failed items that aren't theirs #83

Open
peterhuffer opened this issue Apr 26, 2019 · 0 comments
Open

Configurations can pick up failed items that aren't theirs #83

peterhuffer opened this issue Apr 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@peterhuffer
Copy link
Contributor

peterhuffer commented Apr 26, 2019

Describe the bug
If 2 configurations exist with the same source and destination nodes, it is possible for them to pick up each other's failed items. This is due to the lookup of failed items only taking into account the failure count, source name, and destination name.

See: https://github.com/connexta/replication/blob/master/replication-api-impl/src/main/java/org/codice/ditto/replication/api/impl/SyncHelper.java#L264

Affects version
0.2.2

To Reproduce

  1. Create 2 replications with the same source and destinations, but with different filters.
  2. Replicate on one filter but cause the item to fail.
  3. Run the other configuration. It should attempt to replicate the failed item but fail.

Expected behavior
A configuration should only pick up on its own failed items.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Additional context
N/A

@peterhuffer peterhuffer added the bug Something isn't working label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant