Only do dnf install for cuda images

[ericcurtin]

Should fix container build for Vulkan images

Summary by Sourcery

Enhancements:

• Modify the dnf_install function to conditionally install packages only for CUDA images, avoiding unnecessary installations for Vulkan images.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR modifies the container build script to only perform DNF package installation for CUDA images, removing the default case that was installing packages unnecessarily for Vulkan images. This change is implemented through a modification of the conditional logic in the dnf_install function.

Sequence diagram for dnf_install function logic

sequenceDiagram
    participant Script
    participant DNF
    Script->>DNF: Check containerfile type
    alt containerfile is rocm
        Script->>DNF: dnf install rocm-dev hipblas-devel rocblas-devel
    else containerfile is cuda
        Script->>DNF: dnf install rpm_list
    else containerfile is Vulkan
        Script->>DNF: No installation, rebuild with -DGGML_VULKAN
    end

Loading

File-Level Changes

Change	Details	Files
Modified package installation logic to exclude Vulkan images from DNF installation	Changed else clause to elif specifically for cuda container type Added comment explaining that Vulkan images only need -DGGML_VULKAN flag Removed default package installation case that was affecting Vulkan images	container-images/scripts/build_llama_and_whisper.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide a more detailed commit message explaining why Vulkan images don't need additional packages installed and how this fixes the container build.
• There's a typo in the PR description: 'Shoudl' should be 'Should'

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

LGTM