Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple versions of the windows crate are used #112

Open
gbin opened this issue Nov 25, 2024 · 1 comment
Open

Multiple versions of the windows crate are used #112

gbin opened this issue Nov 25, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@gbin
Copy link
Collaborator

gbin commented Nov 25, 2024

image

Investigate if we can only use one.

@gbin gbin added the good first issue Good for newcomers label Dec 5, 2024
@paulotten
Copy link
Contributor

Doing a code search for windows I don't see it directly included as a dependency in any Cargo.toml files.

After running cargo build in the project root and then searching Cargo.lock in the same directory I see:

(Lines omit from each [[package]] entry for brevity.)

[[package]]
name = "accesskit_windows"
version = "0.20.0"
dependencies = [
 "windows 0.54.0",
]

[[package]]
name = "accesskit_windows"
version = "0.23.2"
dependencies = [
 "windows 0.58.0",
]

[[package]]
name = "gpu-allocator"
version = "0.25.0"
dependencies = [
 "windows 0.52.0",
]

[[package]]
name = "gpu-allocator"
version = "0.26.0"
dependencies = [
 "windows 0.52.0",
]

[[package]]
name = "libmacchina"
version = "7.3.1"
dependencies = [
 "windows 0.39.0",
]

[[package]]
name = "reflink-copy"
version = "0.1.20"
dependencies = [
 "windows 0.58.0",
]

[[package]]
name = "sysinfo"
version = "0.30.13"
dependencies = [
 "windows 0.52.0",
]

[[package]]
name = "wmi"
version = "0.12.2"
dependencies = [
 "windows 0.48.0",
]

Of these only libmacchina appears in a Cargo.toml file (copper-rs/components/monitors/cu_consolemon/Cargo.toml). It has this entry:

libmacchina = "7.3" # 8.0.0+ is not supported by pfetch at the time of writing

Coming back to the windows crate. You don't seem to be directly depending on it anywhere. It seems to a dependency of other dependencies. While you can always update your direct dependencies, I wouldn't worry about dependents of dependents unless there is an underlying security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants