Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cleaning / Better Windows compat #127

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

gbin
Copy link
Collaborator

@gbin gbin commented Dec 4, 2024

No description provided.

@mik90
Copy link
Collaborator

mik90 commented Dec 4, 2024

If you did these manually, there's likely tooling that'll automate this. I found https://github.com/est31/cargo-udeps

Feel free to ignore if you were already using it ofc

@gbin
Copy link
Collaborator Author

gbin commented Dec 4, 2024

If you did these manually, there's likely tooling that'll automate this. I found https://github.com/est31/cargo-udeps

Feel free to ignore if you were already using it ofc

Ha yes, I was using rustrover that just release the feature in the IDE but it is not perfect: some crates contains macros and those macros generated code depends on some crate... Do you know if there is a better way? should we add the dep to the macro crate and reshare the deps or something? @mik90

@mik90
Copy link
Collaborator

mik90 commented Dec 4, 2024

If you did these manually, there's likely tooling that'll automate this. I found https://github.com/est31/cargo-udeps

Feel free to ignore if you were already using it ofc

Ha yes, I was using rustrover that just release the feature in the IDE but it is not perfect: some crates contains macros and those macros generated code depends on some crate... Do you know if there is a better way? should we add the dep to the macro crate and reshare the deps or something? @mik90

Not sure, it's possible Jetbrains is just using some open source dependency linter like udeps but it's also possible they rolled their own

Idk what's best practice, but I imagine that if the macro always generates code that relies on a dep, it's best to make that dep a dep of the macro so at least the version used is documented and versions aren't mixed. I'm not talking from experience though, might be better to look on the rust forums or rust discord.

@gbin gbin merged commit efd7291 into master Dec 4, 2024
3 checks passed
@gbin gbin deleted the gbin/windows-clap3 branch December 4, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants