Fix and refactoring of PcapStreamer #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-k1
suggested changes
Dec 12, 2024
| @@ -235,7 +165,8 @@ mod tests { | |||
|
|
|||
| xt32.reftime = (datetime, clock.now()); | |||
|
|
|||
| while streamer.send_next() { | |||
| // 1076 is the expected payload size for Hesai XT32 | |||
| while streamer.send_next::<1076>() { | |||
There was a problem hiding this comment.
Not a fan of magic static value, since its statically deductible from packet struct with a size_of::<lidar_parser::Packet>
| let socket = UdpSocket::bind("0.0.0.0:2367").unwrap(); | ||
| socket.send_to(data, "127.0.0.1:2368").unwrap(); | ||
| // process | ||
| if streamer.send_next::<1206>() { |
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
| name = "cu-udpinject" | |||
There was a problem hiding this comment.
cu-udp-inject and cu_udp_inject in project would be better consistant with other packages (and easier to read)
luc-k1
reviewed
Dec 12, 2024
| let payload_offset = 42; | ||
|
|
||
| // Extract only the payload, excluding headers and trailing FCS if present | ||
| let payload = &packet.data[payload_offset..payload_offset + PS]; |
There was a problem hiding this comment.
A test is missing : if the packet is smaller than expected, the slicing will panick (case occurs mix a traffic of mixed size packets)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one survived.
Improved it by passing the expected packet payload size to send.