-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]removed deprecation warnings and most duplicate clear warnings #41
base: master
Are you sure you want to change the base?
Conversation
Note that this PR drops compatibility with Coq 8.11 (due to adding the |
I don't understand why you mention only incompatibility with Coq 8.11, Nix CI for bundle 8.12+1.13, 8.13+1.13, 8.12+1.14, 8.13+1.14 are also failures. I only understood that this branch is premature for backward compatibility. |
You're right that 8.12 and 8.13 are also incompatible (I guess for the same reason with locality). But do you want to modify CI configuration in the same branch right now? Or do it later when it's not WIP anymore? |
I wish to wait until the next math-comp meeting to know what policy should maintained with respect to backward compatibility on the master branch. For now I am happy to have a branch that contains fixes for many fixable warnings, but I am don't believe all these warning have the same degree of urgency.
I wanted to make the branch a PR so that potential contributors get a chance to know that this work is indeed in progress. Do you think the README file should be modified to advertise this way of life? |
@ybertot based on my experience in maintaining the RegLang project, I believe a reasonable policy in maintaining a project using MathComp is:
Hence, I think it may be a good idea to separate out deprecation warning fixes that do not drop Coq versions. See for example this RegLang PR, which we will merge when we drop Coq 8.11 support. |
Thanks, I will do as suggested, it may take a few days before I come back to it though. |
Current version has two duplicate-clear warnings that require a little more thinking.