Add customizable equality and hash functions to UDFs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
commented
Jul 11, 2024
Comment on lines
+385
to
+387
| #[ignore] | ||
| #[tokio::test] | ||
| async fn test_parameterized_aggregate_udf() -> Result<()> { |
There was a problem hiding this comment.
This works on main but not here. Unfortunately something else must be broken too 😢
joroKr21
force-pushed
the
udf-eq-hash-v39
branch
3 times, most recently
from
1d7feba to
bfb57c9
Compare
joroKr21
force-pushed
the
udf-eq-hash-v39
branch
from
bfb57c9 to
4a024c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?