Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cose-c should link publicly to openssl/mbedtls #135

Open
BrianSipos opened this issue Oct 11, 2023 · 0 comments
Open

cose-c should link publicly to openssl/mbedtls #135

BrianSipos opened this issue Oct 11, 2023 · 0 comments

Comments

@BrianSipos
Copy link

The link directives listed below are currently marked PRIVATE but this adds burden to users of COSE-C that they must manually add openssl/mbedtls libraries to their own link directives. If these were switched to PUBLIC then CMake would take care of the transitive linking automatically.

target_link_libraries(${PROJECT_NAME} PRIVATE mbedtls)

target_link_libraries(${PROJECT_NAME} PRIVATE ${OPENSSL_LIBRARIES})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant