Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow non semver version #247

Open
wiiznokes opened this issue Jun 19, 2024 · 3 comments
Open

Feature request: allow non semver version #247

wiiznokes opened this issue Jun 19, 2024 · 3 comments

Comments

@wiiznokes
Copy link
Contributor

wiiznokes commented Jun 19, 2024

At least document on the version config field that semver compatible version is required. I know it will get tricky for the update feature, so i understand if this is not implemented. I just lost some time migrating my project to another version format for nothing

@amr-crabnebula
Copy link
Collaborator

I think we can add support for non-semver version, we already have a version_comparator function in the updater, we will just need to change its signature to take String instead of semver::Version.

@amr-crabnebula
Copy link
Collaborator

I am curious though, where exactly did you face issues with sermver, during packaging? which packaging format? or during updating?

@wiiznokes
Copy link
Contributor Author

During packaging for nsis. I finally found a workarround, by using YYYY.MM.0 format. This way, the update should also works if i implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants