Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish race condition #1134

Open
konstin opened this issue Oct 24, 2024 · 1 comment
Open

Publish race condition #1134

konstin opened this issue Oct 24, 2024 · 1 comment
Labels
bug Not as expected

Comments

@konstin
Copy link

konstin commented Oct 24, 2024

When a release of crate-ci/typos is half-published, there can be file not found errors for crate-ci/typos@master users, e.g. https://github.com/astral-sh/uv/actions/runs/11503031175/job/32019380820. This could be prevented by e.g. first uploading all files to a draft release and publishing that draft release only when all files are.

@epage
Copy link
Collaborator

epage commented Oct 24, 2024

While using a draft is a good idea (and we now do so), that isn't sufficient as our release process updates the version in the entry point

{file="../../action/entrypoint.sh", search="VERSION=.*", replace="VERSION={{version}}", min=1},

VERSION=1.26.8

Since we share the tags between the crate and the action, we can't update the entry point after the Release is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

No branches or pull requests

2 participants